andi/perfdb
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Activity

use enum for line type instead of string

Browse Source
This commit is contained in:
Andreas Huber
2018-01-21 11:01:30 +01:00
parent 8f15aba0d5
commit bb7701e7c4
4 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pdb-plotting/src/main/java/org/lucares/recommind/logs/FileBackedDataSeries.java
View File

@@ -12,10 +12,10 @@ public class FileBackedDataSeries implements DataSeries {
private String id;
private String linetype;
private GnuplotLineType linetype;
public FileBackedDataSeries(String id, String title, CsvSummary csvSummary, String linetype) {
public FileBackedDataSeries(String id, String title, CsvSummary csvSummary, GnuplotLineType linetype) {
this.id = id;
this.title = title;
this.csvSummary = csvSummary;

20
pdb-plotting/src/main/java/org/lucares/recommind/logs/GnuplotLineType.java Normal file
View File

@@ -0,0 +1,20 @@
package org.lucares.recommind.logs;
public enum GnuplotLineType {
LINE("line"),
Points("points");
private String gnuplotLineType;
GnuplotLineType(String gnuplotLineType) {
this.gnuplotLineType = gnuplotLineType;
}
@Override
public String toString() {
return gnuplotLineType;
}
}

2
pdb-plotting/src/main/java/org/lucares/recommind/logs/PercentilePlot.java
View File

@@ -193,7 +193,7 @@ public class PercentilePlot implements ConcretePlotter {
values.size());
CsvSummary csvSummary = new CsvSummary(dataFile, values.size(), maxValue, null);
return new FileBackedDataSeries(id, title, csvSummary, "line");
return new FileBackedDataSeries(id, title, csvSummary, GnuplotLineType.LINE);
}
private void defineXAxis(GnuplotSettings gnuplotSettings) {

2
pdb-plotting/src/main/java/org/lucares/recommind/logs/ScatterPlot.java
View File

@@ -88,7 +88,7 @@ public class ScatterPlot implements ConcretePlotter {
final int id = idCounter.getAndIncrement();
final String title = ConcretePlotter.title(groupResult.getGroupedBy(), csvSummary.getValues());
final DataSeries dataSerie = new FileBackedDataSeries("id"+id, title, csvSummary, "points");
final DataSeries dataSerie = new FileBackedDataSeries("id"+id, title, csvSummary, GnuplotLineType.Points);
if (dataSerie.getValues() > 0) {
dataSeries.add(dataSerie);
}