andi/perfdb
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Activity

Pattern.split is faster than StringUtils.splitPreserveAll

Browse Source 
Document the fact, so that I do not have to repeat the same
test a third time.
This commit is contained in:
Andreas Huber
2018-12-17 19:05:34 +01:00
parent 40f4506e13
commit d37508b7a1
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pdb-ui/src/main/java/org/lucares/pdbui/CsvToEntryTransformer.java
View File

@@ -26,9 +26,13 @@ public class CsvToEntryTransformer implements LineToEntryTransformer {
public Optional<Entry> toEntry(final String line) throws IOException { public Optional<Entry> toEntry(final String line) throws IOException {
Optional<Entry> result; Optional<Entry> result;
try { try {
// For future reference:
// Pattern.split is actually faster than StringUtils.splitPreserveAll when the
// test runs longer.
// It seems that the JIT is compiling StringUtils.splitPreserveAll earlier, but
// Pattern.split is ending up getting the faster code in the long run.
final String[] columns = splitPattern.split(line); final String[] columns = splitPattern.split(line);
if (columns.length == headers.length && !columns[0].startsWith("@")) { if (columns.length == headers.length && columns[0].length() > 0 && columns[0].charAt(0) != '@') {
result = createEntry(columns); result = createEntry(columns);
@@ -52,7 +56,6 @@ public class CsvToEntryTransformer implements LineToEntryTransformer {
switch (headers[i]) { switch (headers[i]) {
case "@timestamp": case "@timestamp":
epochMilli = fastISODateParser.parseAsEpochMilli(columns[i]); epochMilli = fastISODateParser.parseAsEpochMilli(columns[i]);
;
break; break;
case "duration": case "duration":
duration = Long.parseLong(columns[i]); duration = Long.parseLong(columns[i]);